Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CHIA-1491 Annotate test_wallet_interested_store.py #18644

Merged
merged 1 commit into from
Sep 30, 2024
Merged

CHIA-1491 Annotate test_wallet_interested_store.py #18644

merged 1 commit into from
Sep 30, 2024

Conversation

AmineKhaldi
Copy link
Contributor

Purpose:

This allows the file (and its users) to benefit from type checking.

Current Behavior:

This file is excluded from mypy type checking.

New Behavior:

This file is now type annotated and included in mypy type checking.

@AmineKhaldi AmineKhaldi added Changed Required label for PR that categorizes merge commit message as "Changed" for changelog Cleanup Code cleanup labels Sep 26, 2024
@AmineKhaldi AmineKhaldi self-assigned this Sep 26, 2024
@coveralls-official Coveralls Official
Copy link

Pull Request Test Coverage Report for Build 11053439304

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
  • 8 unchanged lines in 5 files lost coverage.
  • Overall coverage increased (+0.04%) to 90.976%
Files with Coverage Reduction New Missed Lines %
chia/rpc/rpc_server.py 1 87.83%
chia/wallet/util/wallet_sync_utils.py 1 86.54%
chia/daemon/client.py 1 73.94%
chia/_tests/core/test_farmer_harvester_rpc.py 2 98.02%
chia/wallet/wallet_node.py 3 88.51%
Totals Coverage Status
Change from base Build 11053045680: 0.04%
Covered Lines: 102054
Relevant Lines: 112151
💛 - Coveralls

@AmineKhaldi AmineKhaldi marked this pull request as ready for review September 27, 2024 14:06
@AmineKhaldi AmineKhaldi requested a review from a team as a code owner September 27, 2024 14:06
@pmaslana pmaslana merged commit 8552e35 into Chia-Network:main Sep 30, 2024
370 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arvidn arvidn arvidn approved these changes

Assignees

@AmineKhaldi AmineKhaldi

Labels
Changed Required label for PR that categorizes merge commit message as "Changed" for changelog Cleanup Code cleanup
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@AmineKhaldi @arvidn @pmaslana